You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've made changes in com.theartofdev.edmodo.cropper.CropOverlayView file to fix the cashing issue device with Android P. Please accept the pull request.
@ArthurHub
You have built this library and now it's crashing for every single user on Android P. Can you please take the time reviewing the most critical PR's?
Thanks a lot!
There were multiple PR's open addressing this issue. I don't expect you to always keep this library update.
But after a major android update like P, really critical issues that need to be addressed asap arise.
Maybe put a warning on the readme, that this is currently unmaintained?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made changes in com.theartofdev.edmodo.cropper.CropOverlayView file to fix the cashing issue device with Android P. Please accept the pull request.
Thanks
Nauman